Project

General

Profile

Actions

Feature #787

closed

Allow importing of old tilt alignment parameters in new tilt alignments

Added by Neil Voss over 14 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Python scripting
Target version:
Start date:
07/29/2010
Due date:
% Done:

90%

Estimated time:

Description

will add --import-align to the python.


Related issues 1 (0 open1 closed)

Related to Appion - Bug #1692: importing of old tilt alignment parameters in new tilt alignments sometimes crashesWon't Fix or Won't Do Neil Voss04/05/2012

Actions
Actions #1

Updated by Neil Voss over 14 years ago

Arne to use the ApTiltPickerHelical.py instead of ApTiltPicker.py to get this to work.

in your appion bin folder, mv -v ApTiltPickerHelical.py ApTiltPicker.py

Actions #2

Updated by Neil Voss over 14 years ago

  • Target version changed from Appion/Leginon 2.1.0 to Appion/Leginon 2.2.0
Actions #3

Updated by Neil Voss over 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Neil Voss to Amber Herold

Send to Arne to test.

Actions #4

Updated by Amber Herold over 14 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Amber Herold to Arne Moeller

Neil, in the following files it looks like a couple of lines were still being worked on:

source:trunk/appion/bin/ApTiltPicker.py#L1239
source:trunk/appion/bin/ApTiltPickerHelical.py#L1340

def onFitAll(self, evt):
#self.onUpdate(None) <- not clear why this is no longer needed but remains in code...
if False and (len(self.getArray1()) < 5 or len(self.getArray2()) < 5): <- not clear why this has been removed with "if False".

It actually looks like this function is never even called....

Actions #5

Updated by Arne Moeller about 14 years ago

  • Assignee changed from Arne Moeller to Neil Voss

works fine. Sometimes it crashes for reasons I don't really know. If it crashes it will crash always at the same image pair. After rejecting those images it works fine. I was not able to find any relation between the image pair and why it crashed (f.e. weird or no particle picks)

Actions #6

Updated by Amber Herold over 12 years ago

  • Status changed from In Test to Closed

I've created a new issue with a workaround (#1692) for the bug Arne found so that I can close out this feature for 2.2 release.

Actions

Also available in: Atom PDF