Project

General

Profile

Actions

Bug #1025

closed

appion params['session'] should be replaced by ['sessionname']

Added by Anchi Cheng about 14 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
Python scripting
Target version:
Start date:
11/10/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.0.2
Show in known bugs:
No
Workaround:

r15037 allows either session and sessionname to be assigned in appionScript.py


Description

The latter is more specific. We have a mixture of these. It seems all upload scripts use 'session' as derived from appionScript. Those derived from appionLoop use 'sessionname'.

Actions #1

Updated by Anchi Cheng about 14 years ago

  • Workaround updated (diff)
Actions #2

Updated by Amber Herold about 14 years ago

  • Deliverable set to 2.2 Bug Reduction
Actions #3

Updated by Dmitry Lyumkis about 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Dmitry Lyumkis to Anchi Cheng

there are a ton of revisions associated with this bug:

I went through and manually changed self.params['session'] to self.params['sessionname'], along with minor associated revisions (e.g. documentation, or "is" to "in" error check in uploadImages.py)

Actions #4

Updated by Anchi Cheng almost 14 years ago

r15204, r15206, r15207 removed all cases of params['session'] usage in appionlib.
r15207 removed the depreciated getAllImages since it is not used any more and contains the params['session'] assignment not used anywhere.

Actions #5

Updated by Anchi Cheng over 12 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Anchi Cheng to Amber Herold

This can be considered tested if all AppionScripts are tested because it affects every one of them. You can close this when we are done with the general testing.

Actions #6

Updated by Amber Herold over 10 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF