Feature #1114
closed
convert params['expid'] usage to params['sessionname']
Added by Anchi Cheng almost 14 years ago.
Updated almost 7 years ago.
Status:
Won't Fix or Won't Do
Description
Since expid is only used in appionlib/apParticle.py in guessParticlesForSession and that the function is never called, I am removing the function and put ssessionname (--session in Option parsing) to appionScript.py so that all scripts can have it to reduce redundancy. No myamiweb page actually creates command with --expid as an option even though inc/processing.inc is set to do so if specified.
I am wrong about expid not assgined in the php code. It looks like the new style showOrSubmitCommand is planning to pass expId all the time, which means the one that will be retired is sessionname. I reverted my change in r15124 and committed that to r15126.
Neil, am I right that the plan is to use expid all the time or you have a reason to keep appionloop behaving different from appionscript and use sessionname there instead?
I added the expid stuff so it could be added the database, because we never actually tracked what expid the program was launched from. So, you maybe processing on a merged stack based in 06mar14, but you launch it from 06mar15, the database would know that, so it not always redundant. Make sure you do not break the command line parameter tracking.
guessParticlesForSession() was an idea I developed when I was using the pipeline without the web, I was trying to do all my processing without using myamiweb when I first joined the lab, so we can kill it off now.
I forget how appionloop works, but expid only method is acceptable to me. We use ID numbers everywhere else. It might be good to keep sessionname compatibility for command line hackers, but for myamiweb might as well just use expid.
- Status changed from Assigned to Won't Fix or Won't Do
There are still both of them, part of it was because the requirement for job submission.
Also available in: Atom
PDF