Project

General

Profile

Actions

Bug #1202

closed

Drift graph has a hard-coded pixel and binning size

Added by Anchi Cheng over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Category:
myamiweb
Start date:
02/25/2011
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:
Actions #1

Updated by Anchi Cheng over 13 years ago

  • Category set to myamiweb
  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Amber Herold
  • Target version set to Appion/Leginon 2.2.0

r15417 fix this. Data array is in meters for consistency but show drift rate in graph in Angstrom for convention.

Test:
1. Use a session you are currently running. Finde drift rate measured by Drift Monitor, note the number.
2. Go to myamiweb summary of the session (click on the top left part of an image viewer where it says summary).
3. Click on the graph for drift and see if the last point of the data corresponds to the measuement logged in Leginon.

Any Leginon MSI user can test.

Actions #2

Updated by Amber Herold over 13 years ago

  • Assignee changed from Amber Herold to Anchi Cheng

looks good. I would suggest comments in the code for the magic numbers 1.63e-10 * 4 and 1e-10 to explain what they are and why they are being used.

Actions #3

Updated by Anchi Cheng over 13 years ago

  • Assignee changed from Anchi Cheng to Amber Herold

on second thought, may as well make it to display in pixel if the query for pixelsize fail, save explanation of what that value from tecnai2 is. r15473

Actions #4

Updated by Amber Herold over 13 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Amber Herold to Dmitry Lyumkis

Looks good, ready for test.

Actions #5

Updated by Dmitry Lyumkis over 13 years ago

  • Status changed from In Test to Closed

works for my session

Actions

Also available in: Atom PDF