Bug #12483
openDogPicker can not find any peaks.
0%
Description
broken by Issue #12257
apPeaks.py did not use keyword argument so that the input variables for pyami.imagefun.find_blobs do not match properly.
The new code also does not output moment which apPeaks expect to get.
roundness is a useful parameter to filter. Please fix the bug and add min roundness as an advanced parameter for users on myamiweb such as https://emgweb.nysbc.org/betamyamiweb/processing/runAppionLoop.php?expId=12578&form=DogPickerForm
good default would be a small number like 0.5. 1 is a round object
Updated by Anchi Cheng over 2 years ago
Or default to 0, then everything will pass like the old behavior.
Updated by Sargis Dallakyan over 2 years ago
- Status changed from Assigned to In Test
Thank you Anchi. I just committed changes to fix this in the trunk and beta brunch. Please let me know if I miss something.
Updated by Anchi Cheng over 2 years ago
Hi, Sargis, thanks.
gui looks good and params do change in apPeaks.py. However, minroundness is not sent to imagefun.find_blobs. Most likely because apPeaks call args do not match the order in imagefun.find_blobs and ended up taking the default minroundness in imagefun.
Please revise.
Updated by Sargis Dallakyan over 2 years ago
Hi Anchi, thank you. Made a new commit in the trunk with these changes:
- Removed extra argument in apPeaks.findBlobs
- Calling magefun.find_blobs using all keyword arguments.