Project

General

Profile

Actions

Bug #1831

closed

--ctftilt= always show up in prepRefineForm.php for Frealign

Added by Anchi Cheng over 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
High
Assignee:
Amber Herold
Category:
Web interface
Target version:
Start date:
06/01/2012
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.2.0
Show in known bugs:
Yes
Workaround:

Description

--ctftilt is a flag in the appion script. It does not have a value assignment and should not appear in the resulting command if "Allow Frealign to determine ctf estimation" is selected.

"Allow Frealign to determine ctf estimation" is selected : --noctf
"Allow Frealign to determine ctf estimation" is Not selected and the user want to use only ctftilt result (no gui): --ctftilt
"Allow Frealign to determine ctf estimation" is Not selected and the user want to use any ctf estimation (no gui) (default): (no flag set)

Should decide whether to add to 2.2 or not immediately


Related issues 1 (0 open1 closed)

Related to Appion - Bug #1842: remove "allow frealign to determine ctf" from refine prep pageClosedAmber Herold06/07/2012

Actions
Actions #1

Updated by Amber Herold over 12 years ago

  • Priority changed from Urgent to High
  • Target version changed from Appion/Leginon 2.2.0 to Appion/Leginon 2.2.1
  • Show in known bugs changed from No to Yes

I took a look at the code, and it is not clear to me why --ctftilt= is being added to the command. Parhaps a bug. I'll have to take a closer look after release.

Actions #2

Updated by Amber Herold over 12 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Amber Herold to Anchi Cheng

Merged to 2.2 already

Actions #3

Updated by Amber Herold over 12 years ago

Opps, r16737 belongs to #1820

Actions #4

Updated by Anchi Cheng about 12 years ago

  • Assignee changed from Anchi Cheng to Amber Herold
  • Affected Version changed from Appion/Leginon 2.2.0 (trunk) to Appion/Leginon 2.2.0

Could not find the gui option "Allow Frealign to determine ctf estimation" any more. Was it removed?

Actions #5

Updated by Amber Herold about 12 years ago

Yes, #1842 removes the ctf estimation option.

Actions #6

Updated by Anchi Cheng about 12 years ago

  • Status changed from In Code Review to Closed

code reviewed and tested in case of ctftilt is used and not. Both outpot o.k.

Actions

Also available in: Atom PDF