Feature #1885
closedallowing ctffind result to be corrected by ace2correct?
0%
Description
We have a condition in makestack2.py that reads:
if self.params['fliptype'] == 'ace2image' and self.params['ctfmethod'] is None:
apDisplay.printMsg("setting ctf method to ace2")
self.params['ctfmethod'] = 'ace2'
With more people use never use ace2 estimation method in their trials, and with better consistency in ctf parameters now, should this condition be removed? See #396 for the original reason to put it in. Please comment.
Updated by Gabriel Lander over 12 years ago
I am in support of removing this condition.
Updated by Neil Voss over 12 years ago
I support removing this. The original reason (I think I put it in) was because ace2correct would only take the ace2estimate ctf.txt file and we did not implement the ability to write a ctf.txt on the fly for other values, which I see is now implemented.
CTFFind, ACE1, and ACE2 all use the same parameters for phase flipping, but I would be concerned about the Weiner filter because (I think) the noise and envelop models are involved (CTFfind does not estimate this). I guess I assumed that ACE2 read these from a file, but maybe it just recalculates them, Craig can you confirm?
Updated by Neil Voss over 12 years ago
I see my last comment, "we should probably change this in the future"
Updated by Anchi Cheng over 12 years ago
- Category set to Python scripting
- Status changed from New to In Code Review
- Assignee set to Neil Voss
- Target version set to Appion/Leginon 3.0.0
r16861 is changed now. No more ace2 estimation restriction.
Updated by Neil Voss over 12 years ago
- Status changed from In Code Review to In Test
- Assignee changed from Neil Voss to Anchi Cheng
looks good