Project

General

Profile

Actions

Feature #2216

closed

Bug #2202: K2 DD corrected frame alignment fails with certain gain references

Specify reference image to be used in raw frame processing

Added by Anchi Cheng almost 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Category:
Python scripting
Target version:
Start date:
01/21/2013
Due date:
% Done:

0%

Estimated time:

Description

Useful when the reference goes off and need to use later reference to gain/dark correct the frames

Actions #1

Updated by Anchi Cheng almost 12 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Dmitry Lyumkis

r17344 and r17345 commited the feature. add option --refimgid=1234 to use the bright/dark image associated with the said id for the correction.

Should see lines corresponding to your specified image and references like this at the first loading.

 ... Reference image comes from 12dec22a_gr2_00011gr_00031sq_v02_00021hl_00004ed
!!! WARNING: Use Norm Reference 12dec22a_23131147_21_3840x3712_norm_0

Dmitry, please code review and test.

Actions #2

Updated by Dmitry Lyumkis almost 12 years ago

  • Status changed from In Code Review to Closed
  • Assignee changed from Dmitry Lyumkis to Anchi Cheng

this works, thanks Anchi!

catchupDDAlign.py gave an error. It looks like "camq['save frames'] = True" was set in getFrameImageCamera(), and 'save frames' is not a key in leginondata.py. I had to add that in, and it's running now, but I realized that I didn't associate the revision with this issue.

Actions #3

Updated by Anchi Cheng almost 12 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from Anchi Cheng to Dmitry Lyumkis

Dmitry, "save frames" has been a key in camera_params which CameraEMData includes since r15082. I ran the function with 12dec22a session and it returns fine without your change.

Actions #4

Updated by Dmitry Lyumkis almost 12 years ago

you are correct, sorry about that. I was getting an error in catchUpDDAlign.py, complaining about a missing key in leginondata, and I started looking in there. It turns out that there was a typo in the -expid option, and appion was looking at a different session, and therefore a different camera. I must have overlooked the fact that I made several changes prior to rerunning. I committed the old one.

Actions #5

Updated by Dmitry Lyumkis almost 12 years ago

  • Status changed from Assigned to In Test
Actions #6

Updated by Dmitry Lyumkis almost 12 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF