Bug #2285
open
imageloader.py and uploadImages.py insert image into the database before saving the image
Added by Anchi Cheng over 11 years ago.
Updated over 11 years ago.
Affected Version:
Appion/Leginon 3.0.0
Description
This causes problem to imcached that query images in the database and want to cache the image for web image viewers. Often that the file is not completely saved before the read starts by imcached.
Jim wants to make it a rule that the image should be saved to Leginon image path before database insertion.
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Neil Voss
r17443 read mrc in as num array and save to destination through imagedata.insert() Since these programs are not used for stack uploading, it should be o.k. to load into memory. Otherwise, the fake image in the imagedata would overwrite the copied mrc image if done before the imagedta.insert()
This need to be merged into myami-2.2-redux
Neil I hope you don't recall a case where reading the image into memory is not possible in upload.
Hi Anchi,
My only worry about this is that if numpy or sinedon goes buggy again and does not properly clear the memory then you could have a memory leak, which is why we did it in the first place (????). If it works though I cannot argue against it.
- Status changed from In Code Review to In Test
- Assignee changed from Neil Voss to Anchi Cheng
- Assignee changed from Anchi Cheng to Saikat Chowdhury
Neil,
If numpy causes memory leak, Leginon won't be stable any way. I did the copy in the first place because copy is faster read and then write.
Saikat,
Please test this for me. Just upload some image as you have been doing and see if it runs. Update the issue with whether it is successful. If so, the issue can be closed.
Hi Anchi,
I just uploaded 10 micrographs in the project "13mar07z - test upload".
It seems to have worked fine.
I can view the micrographs in the image viewer do FFT etc.
It seems to work fine. For some reason I can't see this project/session in the project/session list page in appion.
If you click on the 'show all' button, it should show. I didn't know about this feature until now, neat.
Also available in: Atom
PDF