Bug #2584
closed
mask image are saved twice due to user error
Added by Anchi Cheng about 11 years ago.
Updated almost 11 years ago.
Status:
Won't Fix or Won't Do
Affected Version:
Appion/Leginon 2.1.0
Description
In this particular case, some user ran manual masking at one disk location for half of the data and then launched another one from another location, starting from the beginning. This causes confusion since the database only considers one rundir. It just adds the duplicated region as additional mask.
This causes two problems:
1. The first rundir has only partial mask.png while the second rundir has all partical mask.png with some duplication with the first. Since they are manually created, they are not identical, even though either of the duplicate would be good. When the next script that uses the mask looks for the png file in the first rundir, it crashes when it looks for ones not in there.
2. The part that keeps mask region has more regions to keep than there are regions in segmentation of either of the duplicated mask png image.
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Amber Herold
- Target version set to Appion/Leginon 3.0.0
Can't remember who the fix was for, but the fix must have worked. Can be closed after code review.
- Assignee changed from Amber Herold to Anchi Cheng
I see how the fix addresses issue 2. Does that also fix issue 1?
- Status changed from In Code Review to Won't Fix or Won't Do
- Assignee changed from Anchi Cheng to Amber Herold
No, it doesn't.
Appion does not prevent people from changing rundir at the python level probably by necessity when a particular disk becomes inaccessible and the fact that such bug fix requires a text search. For example, there may be hundreds of dogrun1 per project and only ones belong to the same session is a problem. If the users are changing runname and/or rundir in python command, it is hard to find the right pattern for the search.
Also available in: Atom
PDF