Project

General

Profile

Actions
Copy link

Bug #2614

open

Call-time pass-by-reference for function is deprecated in php 5.4

Added by Anchi Cheng almost 11 years ago. Updated almost 11 years ago.

Status:
In Code Review
Priority:
Normal
Assignee:
Anchi Cheng
Category:
-
Target version:
-
Start date:
01/02/2014
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.0.0
Show in known bugs:
No
Workaround:

Description

I have php 5.4 on my new mac and it shows this as fatal error in

myamiweb/processing/uploadimage.php?projectId=2

In php 5.3, this is just a deprecation warning.

The following change on line 66 of myamiweb/processing/inc/refineJob.inc fixes it. Gather there will be more.

$this->sortJobs(&$this->runJobs);

to

$this->sortJobs($this->runJobs);
Actions
Copy link
 #1

Updated by Amber Herold almost 11 years ago

It looks like pass-by-reference notation has been moved to the function definition rather than the function. To keep the same behavior, the & needs to be at the function definition. I'll check it out and make sure it is.

Actions
Copy link
 #2

Updated by Amber Herold almost 11 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Amber Herold to Anchi Cheng

I did not find any other places with the same issue, so hopefully this covers it.

Actions
Copy link

Also available in: Atom PDF