Project

General

Profile

Actions

Feature #368

closed

signature in appion

Added by Gabriel Lander over 14 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
-
Target version:
-
Start date:
04/21/2010
Due date:
% Done:

0%

Estimated time:

Description

wrapper for the batch version of signature, which can be found here:
http://emlab.rose2.brandeis.edu/signature
no threading support right now

r13564


Related issues 1 (0 open1 closed)

Related to Appion - Bug #456: Hide Signature feature Closed05/11/2010

Actions
Actions #1

Updated by Amber Herold over 14 years ago

  • Assignee changed from Amber Herold to Gabriel Lander

Gabe,
I only looked at this briefly, but this is scary to me:
while proc.poll() is None:
sys.stderr.write(".")
time.sleep(waittime)
logf.flush()
proc.wait()

I suppose when threading is implemented that will go away?

Also on lines 47 and 153 of signaturePicker.py there seems to be a superfluous i in the for loops, or did I miss something?

I think that for the release, we will most likely hide the signature tool with the config file parameter HIDE_FEATURE since we have not had a chance to test it and don't have it installed here. To enable it, just set HIDE_FEATURE to true in config.php under myamiweb.

Actions #2

Updated by Gabriel Lander over 14 years ago

  1. Hi Amber,
    sorry, I copied this code directly from "apFindEM.py", feel free to fix it however you see necessary.
Actions #3

Updated by Gabriel Lander over 14 years ago

oh, and the "i" you see in signaturePicker.py is indeed superfluous, again copied from code somewhere else. You can take it out.

Actions #4

Updated by Gabriel Lander over 14 years ago

  • Assignee changed from Gabriel Lander to Amber Herold
Actions #5

Updated by Amber Herold over 10 years ago

  • Status changed from In Code Review to Closed
Actions

Also available in: Atom PDF