Bug #443
closed
postproc.php has hard-coded link to appion directory change to config.php
Added by Neil Voss over 14 years ago.
Updated about 9 years ago.
Affected Version:
Appion/Leginon 2.0.1
Description
postproc.php has hard-coded link to appion directory.
Need to add a appion directory that is accessible by the web server to config.php
It is a rarely used function, but you cannot see the amplitude curves on the page without data from the appion directory
- Target version set to Appion/Leginon 2.1.0
- Affected Version set to Appion/Leginon 2.0.1
- Target version changed from Appion/Leginon 2.1.0 to Appion/Leginon 2.2.0
- Show in known bugs set to No
- Deliverable set to 2.2 Bug Reduction
- Status changed from Assigned to Closed
- Assignee deleted (
Eric Hou)
- Status changed from Closed to New
If you look in the file, line 30, you see:
$appionlibdir = "/ami/sw/leginon/betaleginon/appion/appionlib";
- Assignee set to Amber Herold
My goodness that is a nasty line of code! Thanks Neil. perhaps trying to work with bronchitis was not the best idea. I'll take care of it this week.
- Status changed from New to In Code Review
- Assignee changed from Amber Herold to Anchi Cheng
- Priority changed from Low to High
I added appionlibdir to the myamiweb config file, still to do - I need to add this to the configuration wizard (#1717).
I modified both postproc.php and hippostproc.php as they have the same code. I also created a function to join paths and created a path class to put it in along with a few other functions that are sprinkled around and needed to be consolidated. Haven't decided if the path class should use DIRECTORY_SEPARATOR everywhere instead of "/". Thoughts?
I thought DIRECTORY_SEPARATOR is used in case that the system ( like Windows) uses something other than '/'.
I'm just not sure how DIRECTORY_SEPARATOR is set. Is it based on the web server OS? If we are creating paths that are to be run on a distant processing server, could we be using the wrong separator? Since we only run on Linux does it even matter? I also saw articles saying the separator does not matter anymore b/c windows will handle unix style fine now. Plus we have an entry in the config file for each processing host for what the separator is. So for the cluster class, I am using that value rather than DIRECTORY_SEPARATOR or "/". I think the code is OK as is for now, but I would like to make all the functions in the Path class a bit more uniform, perhaps after the 2.2 release.
- Status changed from In Code Review to Closed
Also available in: Atom
PDF