Bug #450
closed
Histograms are not properly displaying data
Added by Neil Voss over 14 years ago.
Updated over 14 years ago.
Description
I noticed that my Euler graph should have a mean of 0.17, meaning that most values are less than one, but the histogram show that the predominant value was 2. I dug a little deeper and realized the code was all wrong and was slower than it needed to be.
I've attached the original and fixed versions of the Euler graph. I am very pleased with these results and it has an average speed up of about 5 fold.
Files
- Status changed from Assigned to In Code Review
- Assignee changed from Neil Voss to Amber Herold
This affects all plots. So look at defocus values, euler plots, x,y coordinates, alignment scores, etc. when testing.
Note: do not be alarmed this phenomenon only affects plots with hard edges, i.e., most of the data is 0 or 1 as the Euler plot (above) or maximum likelihood plots. Gaussian plots like defocus values should be unaffected.
- Assignee changed from Amber Herold to Neil Voss
Great catch Neil.
It looks like the old stuff is just commented out. If you think it is necessary to leave that code there for historical/educational purposes could you please add a comment explaining why it is there. Otherwise I would just remove it to avoid future confusion.
- Assignee changed from Neil Voss to Amber Herold
- % Done changed from 0 to 100
removed old algorithm, r13868.
- Assignee changed from Amber Herold to Neil Voss
- Status changed from In Code Review to In Test
- Assignee changed from Neil Voss to Anke Mulder
can you check out a few histograms and make sure they look good.
- Target version set to Appion/Leginon 2.0.0
- Status changed from In Test to Closed
Also available in: Atom
PDF
