Appion

Neil, are you still actively working on this one? I'd like to get the wrapper stuff done as soon as possible, so I can take it over if needed. I'm trying to figure out what still needs to be done to the code to complete use of the wrapper. Looks like showing the command prepends the path to the wrapper, but submitting the command does not. Do we need to add the path to the submitted commands as well? Is there anything else that needs to be done for this?

r14692 changes $cmd to $command to match the call to showOrSubmitCommand(). I decided to go with $command rather than $cmd because it is more clear.

I modified DogPicker to use showOrSubmitCommand. I'm not thrilled with how I'm handling testing of a single image...followed the example of runMaskMaker.php. I may try to refactor this portion if I find a good way to do it.

Hi Amber, you Dog picker example is why I left the particle picker untouched. I was not sure how to do the testing part. Sorry for the late reply.

Link to wrapper testing page: Wrapper_Testing

I updated runJpgMaker in r15490, but I'm not pleased with the way the test feature works. You need to press "show command" to get the test command, but an error is displayed because the test image has not yet been processed. Then the user needs to run the command and return to the form, select the option for testimage again and press "show command" again to see the test results. Very strange. I spent some time trying to change the interface so the user could press a button after running the command to show the results, but hit some snags. Rather than spend too much time on this one file, I just added some instruction for the user in the header, but it would be nice to return to this some day to improve the user experience.

For code review, the biggest thing to look for might be copy/paste errors.

This will be a difficult one to test. For each file changed:
0. make sure you are using an appion installation that has the wrapper path defined in the config.php file.
1. Fill out form and press just show command. Ensure the appion wrapper path as defined in config.php is prepended to the command.
2. Ensure there is a citation for the software used at the top of the page.
3. Fill in the form again and press the run button. I'll say this is almost optional since "show" and "run" go through the same function. But it can't hurt to test it.
4. Fill in the form again but leave out something that is required. Ensure an error message is displayed.
5. If there is an option to test an image, try testing an image using both "run" and "show". Ensure they use the wrapper path.