Project

General

Profile

Actions

Bug #748

open

Defocal pairs shifts are failing on DD data

Added by Neil Voss over 14 years ago. Updated over 14 years ago.

Status:
In Test
Priority:
Normal
Category:
Python scripting
Start date:
07/19/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
Pre-2.0
Show in known bugs:
No
Workaround:

Description

Defocal pairs shifts are failing on DD data

Actions #1

Updated by Neil Voss over 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Neil Voss to Amber Herold
Actions #2

Updated by Amber Herold over 14 years ago

  • Assignee changed from Amber Herold to Neil Voss

Neil, looks like you are clipping non-square images and throwing away the excess pixels. Are there any consequences of this that people should be aware of? Image off center, any possibility of throwing out relevant info?

Actions #3

Updated by Neil Voss over 14 years ago

  • Assignee changed from Neil Voss to Amber Herold

It is just clipping the square because our cross_correlation algorithm does not work with rectangles. The clipping is not saved it only used for this function.

When we get the new camera, Jim will probably fix the cross_correlation algorithm to work with rectangular images, but I don't want to do that for fear of breaking Leginon.

Actions #4

Updated by Amber Herold over 14 years ago

  • Status changed from In Code Review to In Test
Actions #5

Updated by Amber Herold over 14 years ago

  • Assignee changed from Amber Herold to Dmitry Lyumkis
Actions #6

Updated by Dmitry Lyumkis over 14 years ago

  • Assignee changed from Dmitry Lyumkis to Neil Voss

Neil, What's the best way to test this before the release? Could you provide some procedures?

Actions #7

Updated by Neil Voss over 14 years ago

  • Assignee changed from Neil Voss to Dmitry Lyumkis

You can test it on any dataset with defocal pairs. Just pick on ef and make a stack from en.

Actions

Also available in: Atom PDF