Feature #845
closed
It is too confusing to allow image upload to a real Leginon session
Added by Anchi Cheng about 14 years ago.
Updated almost 7 years ago.
Description
This is not really a bug. Images uploaded are under their own preset, but it does promote
bad habit.
Currently, uploaded images are not associated with a real microscope/camera. Mixing real data collection by Leginon with uploaded images can be a confusing. Now that image upload always uses appionTEM and appionCamera as instruments, we can make the mixing a forbidden path.
One day I will write a special imageloader for those acquiring film data by Leginon to upload their scanned film that matches their Leginon record.
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Amber Herold
- % Done changed from 0 to 100
add in r14722 on imageloader.py
add webserver side blocking in r14724
The query assumes any images collected from tem other than appionTEM invalid. This will also reject any old sessions before we enforced appionTEM usage for uploading. I think that is a reasonable sacrifice.
Testing:
1. choose a session with real Leginon data collection and click to go to processing page.
The processing menu should not show the option for "Upload more images"
2. If you force the page uploadimage.php to use that session by assigning expId, it will show the page. However, it should
bounce back when you make it to show command or run.
3. If you force the python script to run on a terminal by giving the session name, it should not upload the images, either.
4. Try 2. and 3. on a valid uploaded session that is created since 2.0
- Subject changed from It is dangerous to allow image upload to a real Leginon session to It is too confusing to allow image upload to a real Leginon session
- Status changed from In Code Review to In Test
- Assignee changed from Amber Herold to Eric Hou
- Assignee changed from Eric Hou to Pick-Wei Lau
- Status changed from In Test to Closed
Also available in: Atom
PDF