Bug #886
closed
tomoreport give error on empty movie
Added by Anchi Cheng about 14 years ago.
Updated almost 14 years ago.
Affected Version:
Appion/Leginon 2.0.2
Description
Happens on tiny tomogram that makes empty slice through movie
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Amber Herold
- % Done changed from 0 to 100
only find scale through movie dimension if the movie dimension exists and valid. Use projection image size when the movie (made with 5x binning in z-direction and can end up empty if too small such as in a test) is empty.
testing:
1. Just visit cronus3 myamiweb/processing/tomoreport.php?expId=8045&tomoId=23. You should see a scaled up projection image from a 4x4x5 tomogram and no Slice Through movie.
2, A case with working movie can be found on cronus3 myamiweb/processing/tomoreport.php?expId=8045&tomoId=1
- Status changed from In Code Review to In Test
if (file_exists($projfile))
$imagesize = getimagesize($projfile); <-- Is it possible for $imagesize to be invalid?
$maxcolwidth = 400;
echo "<tr><td>";
if ($flvwidth > 0 && $flvheight > 0) {
$colwidth = ($maxcolwidth < $flvwidth) ? $maxcolwidth : $flvwidth;
$rowheight = $colwidth * $flvheight / $flvwidth;
} else {
$colwidth = ($maxcolwidth < $imagesize[0]) ? $maxcolwidth : max($imagesize[0],40); <-- Huh?
$rowheight = $colwidth * max($imagesize[1],0) / max($imagesize[0],1);
}
The code above is a bit confusing...Anchi says the 40 is an arbitraty value to account for some of her tests, but in real practice the value should not get that small.
- Assignee changed from Amber Herold to Eric Hou
- Assignee changed from Eric Hou to Anchi Cheng
- Assignee changed from Anchi Cheng to Eric Hou
That is what it is supposed to be. That tomogram is so small it could not be made into slice movie. The other test case is the one that has the movie.
- Status changed from In Test to Closed
Also available in: Atom
PDF