Bug #2107
open
USE_REDUX_CACHE in myamiweb config.php is not necessary
Added by Anchi Cheng almost 12 years ago.
Updated almost 12 years ago.
Assignee:
Sargis Dallakyan
Affected Version:
Appion/Leginon 3.0.0
Description
Now that php cache is fixed and redux cache stable, the variable in config.php is not really necessary since redux may have cache turned on whether this is assigned to true or false.
This bug fix will involve taking it off config.php, removing it from setup wizard and autoinstaller if present, and remove its usage in myamiweb/inc/cachedb.inc
There is also a cacheon variable passed into inc/image.inc that might not be needed any more.
Amber&Sargis,
Please check if I miss something or if you disagree with me on this.
Sounds good to me. Would you like me to implement this? I'm waiting for responses regarding what to do with CTF and this is the next most important issue right now.
- Status changed from New to Assigned
- Assignee changed from Anchi Cheng to Amber Herold
- Status changed from Assigned to In Code Review
- Assignee changed from Amber Herold to Sargis Dallakyan
Sargis,
Can you please review these changes?
The configuration file for the trunk installations will need to be updated to remove this option, then we can test out redux tomorrow when the code is updated.
I have not seen any issue with the config wizard, so please let me know if you still do.
After we test redux tomorrow, please set this issue to "merge" and assign back to me so that I can merge the changes to myami-2.2redux branch.
After we merge, we will need to update the config file for that installation as well.
Sargis, I went ahead and modified the config files on longboard and cronus3 betamyamiweb installations. After you have a chance to review the changes and it has been tested, I can merge.
Also available in: Atom
PDF