Project

General

Profile

Actions
Copy link

Bug #2308

open

Can not set boolean option to False if the action is true and default is alsow true

Added by Anchi Cheng over 11 years ago. Updated over 10 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/26/2013
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.2.0
Show in known bugs:
No
Workaround:

Description

For example, a few options in appionlib/apRefineJobXmipp. are like that:

self.parser.add_option("--DoComputeResolution", dest="docomputeresolution", action="store_true",
                        help="Compute resolution or not", default=True)
self.parser.add_option("--DoLowPassFilter", dest="dolowpassfilter", action="s
tore_true",                        help="This lowpass filter will be applied for the generation of the n
ext reference", default=True)

These need to coordinate with myamiweb gui as well

Actions
Copy link
 #1

Updated by Anchi Cheng over 11 years ago

  • Status changed from New to Assigned
  • Assignee set to Dmitry Lyumkis
  • Priority changed from Normal to Urgent

Dmitry,

Please at least list which ones need to be corrected now even if you can't correct them immediately.

Actions
Copy link
 #2

Updated by Dmitry Lyumkis over 11 years ago

  • Assignee changed from Dmitry Lyumkis to Amber Herold

they should both be defaulted to true, I think. Probably the cleanest way to do this would be to have a flag --DoNotLowPassFilter, default destination "donotlowpassfilter" as False (i.e. DO a lowpass filter), and if the option is specified, only then set the option to True (i.e. DO NOT lowpass filter). Otherwise, in the meantime, maybe we can just add two flags, --DoNotLowPassFilter and --DoNotComputeResolution that would set destinations "dolowpassfilter" and "docomputeresolution" to False, respectively.

Actions
Copy link
 #3

Updated by Amber Herold over 10 years ago

  • Status changed from Assigned to New
  • Assignee deleted (Amber Herold)
  • Priority changed from Urgent to Normal
Actions
Copy link

Also available in: Atom PDF