Project

General

Profile

Actions

Bug #2396

closed

uploadEMANRefine.py does not handle mirror correctly

Added by Anchi Cheng over 11 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
-
Target version:
Start date:
06/14/2013
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.0.0
Show in known bugs:
No
Workaround:

Description

The code that convert Eulers with mirror to Eulers without mirror was never applied due to

if mirror is True:

when mirror is set to an integer in the previous line

This reconstruction based on the uploaded Euler therefore looks like a merged of the two mirrored structure.


Related issues 2 (1 open1 closed)

Related to Appion - Bug #2397: ParticleFile produced by EMAN for reconUploader does not match particle correctlyIn Code ReviewDmitry Lyumkis06/14/2013

Actions
Related to Appion - Bug #1873: confict in icosahedral convention and refinement packagesClosedAnchi Cheng06/20/2012

Actions
Actions #1

Updated by Anchi Cheng over 11 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Dmitry Lyumkis

r17655 fix this plus adding some comments

Actions #2

Updated by Dmitry Lyumkis over 11 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Dmitry Lyumkis to Amber Herold

this looks good. I just checked the other uploaders (Xmipp and ML3D), and they have the mirror set to a boolean, which would make the "if mirror is True" statement valid rather than "if mirror". This is another option for the code.

Actions #3

Updated by Amber Herold over 10 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF