Appion

makestack breaks due to: rewritten getBestCtfValue method

The following lines pertain to previously checked in version but make no sense in the current context of getBestCtfValue

if res50 > bestres50:
                        bestres50 = res50
                        bestctfvalue = ctfvalue

Note that the old getBestCtfValue only worked properly with more than one CTF present if the following line was changed to:

if res50 < bestres50:

LOG running makestack:

Warning: You have not configured Images path in leginon.cfg! Using current directory.
... Time stamp: 14sep19m47
... Function name: makestack2
... Appion directory: /opt/qb3/myami-trunk/appion
... Using split database
Connected to database: 'ap77'
... Committing data to database
... Boxsize 512 contains the primes: [2, 2, 2, 2, 2, 2, 2, 2, 2]
... Found project id=77 for session 14sep16a in 7.7 msec
... Run directory: /k2data/appion/showes/14sep16a/stacks/stack2
... Writing function log to: makestack2.log
... Running on host: octopus
... Uploading ScriptData....
... Running on host: octopus
... Found 24 processors on this machine
... Running on host: octopus
... Looking up session, 14sep16a
... Running Appion version 'trunk-r18565M'
... Creating new done dictionary: makestack2.donedict
... Querying database for preset 'en-a' images from session '14sep16a' ...
... Found 506 images in 0.86 sec
... Remove processed images

Traceback (most recent call last):
File "/opt/qb3/myami-trunk/appion/bin/makestack2.py", line 1213, in <module>
makeStack.run()
File "/opt/qb3/myami-trunk/appion/appionlib/appionLoop2.py", line 65, in run
self._getAllImages()
File "/opt/qb3/myami-trunk/appion/appionlib/appionLoop2.py", line 500, in _getAllImages
self._removeProcessedImages()
File "/opt/qb3/myami-trunk/appion/appionlib/appionLoop2.py", line 768, in _removeProcessedImages
skip, reason = self.skipTestOnImage(imgdata)
File "/opt/qb3/myami-trunk/appion/appionlib/appionLoop2.py", line 711, in skipTestOnImage
elif self.reprocessImage(imgdata) is False:
File "/opt/qb3/myami-trunk/appion/appionlib/apParticleExtractor.py", line 451, in reprocessImage
if self.checkCtfParams(imgdata) is False:
File "/opt/qb3/myami-trunk/appion/appionlib/apParticleExtractor.py", line 160, in checkCtfParams
ctfvalue = self.getBestCtfValue(imgdata)
File "/opt/qb3/myami-trunk/appion/appionlib/apParticleExtractor.py", line 148, in getBestCtfValue
return ctfdb.getBestCtfValue(imgdata, sortType=self.params['ctfsorttype'], method=self.params['ctfmethod'], msg=msg)
File "/opt/qb3/myami-trunk/appion/appionlib/apCtf/ctfdb.py", line 205, in getBestCtfValue
if res50 > bestres50:
NameError: global name 'res50' is not defined