Project

General

Profile

Actions

Bug #3935

closed

combining stack containing virtual stack fails to add particles in stackfile

Added by Anchi Cheng almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
02/07/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.2
Show in known bugs:
No
Workaround:

Description

The resulting stack lacks the particle stack file but has apStackParticleData. How should we handle this ? I can add a check function before attempting to combine as workaround if there is no solution already.

Actions #1

Updated by Gabriel Lander almost 9 years ago

hmmm, hadn't thought about this. Haven't combined a stack in years, I didn't know this was still an option.
I think the best thing would be to check for a virtual stack upon launching the combine command, and then generate a temporary one for the purposes of combining the stacks. Then delete the temp stack file.
What do you think?

Actions #2

Updated by Anchi Cheng almost 9 years ago

  • Assignee changed from Gabriel Lander to Anchi Cheng

Gabe,

Sounds good. Do you have a function that I can call to generate stack or should I migrate the one in generateStack.py to do so generally ?

Actions #3

Updated by Gabriel Lander almost 9 years ago

I don't have a function in appion, I would just grab whatever I used for the generateStack.py script.

Actions #4

Updated by Anchi Cheng almost 9 years ago

r19511 moves generateMissingStack function to apVirtualStack.py so that it is callable by combinestack.py
r19512 use it in combinestack.py

Actions #5

Updated by Anchi Cheng almost 9 years ago

  • Status changed from Assigned to In Test
  • Assignee changed from Anchi Cheng to Gabriel Lander
  • Target version set to Appion/Leginon 3.2

Gabe,

See if it works for you. The runname, rundir and jobtype are for standard form generation. see Issue #3918

Actions #6

Updated by Gabriel Lander over 8 years ago

  • Status changed from In Test to Closed

works

Actions

Also available in: Atom PDF