Bug #3935
closedcombining stack containing virtual stack fails to add particles in stackfile
0%
Description
The resulting stack lacks the particle stack file but has apStackParticleData. How should we handle this ? I can add a check function before attempting to combine as workaround if there is no solution already.
Updated by Gabriel Lander over 8 years ago
hmmm, hadn't thought about this. Haven't combined a stack in years, I didn't know this was still an option.
I think the best thing would be to check for a virtual stack upon launching the combine command, and then generate a temporary one for the purposes of combining the stacks. Then delete the temp stack file.
What do you think?
Updated by Anchi Cheng over 8 years ago
- Assignee changed from Gabriel Lander to Anchi Cheng
Gabe,
Sounds good. Do you have a function that I can call to generate stack or should I migrate the one in generateStack.py to do so generally ?
Updated by Gabriel Lander over 8 years ago
I don't have a function in appion, I would just grab whatever I used for the generateStack.py script.
Updated by Anchi Cheng about 8 years ago
r19511 moves generateMissingStack function to apVirtualStack.py so that it is callable by combinestack.py
r19512 use it in combinestack.py
Updated by Anchi Cheng about 8 years ago
- Status changed from Assigned to In Test
- Assignee changed from Anchi Cheng to Gabriel Lander
- Target version set to Appion/Leginon 3.2
Gabe,
See if it works for you. The runname, rundir and jobtype are for standard form generation. see Issue #3918