Appion

Please include error chacks for the clusterconfig.php file. refer to #595

Here are a few to look at. I was thinking it may not make much sense to say a float must have a certain number of decimal places. When someone is typing in a number they should be able to type 1.1234 or 1. or 1 or 1.12 and we can do with it whatever we need to do.

Floats

^\d*\.?\d{0,2}$ - float with a max of 2 decimal places. May omit point. (make the 2 a variable)
^\d*\.\d{2}$ - float with exactly 2 decimal places. May not omit point.
^\d*\.?\d*$ - float with any number of decimal places. May omit point.
^[+|-]{0,1}\d*\.?\d*$ - float with any number of decimal places. May omit point. May begin with positive or negative sign.

None handle comas(,). If you want comas you can do something like this: ^[+|-]{0,1}[\d,]*\.?\d*$ but it allows things like +,,,.

Paths

^((\.\./|/)+(\.\./|[\w/\-\\])*(\.\w+)*)$ - Path that must begin with / or ../ then allows alpha/num, underscore, dash and ../ with optional file extensions.
^((\.\./|[\w/\-\\])*(\.\w+)*)$ - Path that does NOT require / or ../ in the front then allows alpha/num, underscore, dash and ../ with optional file extensions.

URL - may need it sometime?

^(http|https|ftp)\://[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,3}(:[a-zA-Z0-9]*)?/?([a-zA-Z0-9\-\._\?\,\'/\\\+&%\$#\=~])*$ - url requires http (not perfect but a starting point from RegExLib.com)

Hi Amber!

The regular expressions do not work for me.
Try to go to : http://www.spaweditor.com/scripts/regex/index.php.
This is a php tester.

Select "preg_match"

Thanks.

They all work for me. What strings are breaking?
One problem might be that what I listed does not have delimiters defined which are required for using preg_match. For example, the floats could use / as delimiters:
/^[+|-]{0,1}\d*\.?\d*$/

The path and url is better with a hash(#) as the delimiter. For the URL, since we are using # we need to escape the # that occurs in the actual expression.
#^(http|https|ftp)\://[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,3}(:[a-zA-Z0-9]*)?/?([a-zA-Z0-9\-\._\?\,\'/\\\+&%\$\#\=~])*$#

Also, I think that your original expressions should be modified slightly. For example:
/[^0-9]/ --> /^[0-9]$/
/[^A-Za-z]/ --> /^[A-Za-z]$/
/[^A-Za-z ]/ --> /^[A-Za-z ]$/
/[^A-Za-z0-9 ]/ --> /^[A-Za-z0-9 ]$/

This way, rather than looking for something that does not fit the pattern, you look for something that does fit the pattern. Then if preg_match does NOT find a match, validateReq() returns false, if it does find a match it returns true. This will keep things more consistent and easier to write more complicated regular expressions.

#^/[\w/\-]*$# - simplified path, requires a single / in front followed by any number of alphanumeric - or /.

added "path_exit" and "forder_permission" in the the formValidator class. r14458

add validation for remote cluster and also validate the server has installed php ssh2 module. r14460

Great work!

Will check in changes after I install ssh2 on fly so I can complete testing.

Fixed¶

I updated some names. Changed forder to folder and exit to exist. Corrected some error messages.

Testing:¶

received this message when supplied an incorrect DB server name or otherwise can't connect (password or username wrong):
Warning: mysql_close(): no MySQL-Link resource supplied in /home/amber/amiworkspace/myami/myamiweb/inc/mysql.inc on line 79

Similar warnings are displayed when other errors occur as well.
Warning: mkdir() [function.mkdir]: Permission denied in /home/amber/amiworkspace/myami/myamiweb/inc/formValidator.php on line 329

Warning: mkdir() [function.mkdir]: No such file or directory in /home/amber/amiworkspace/myami/myamiweb/inc/formValidator.php on line 329

It would be nice to capture these messages and maybe send them to a log file rather than the UI if there is a way to do that.

Suggestions¶

Would it be possible to use

exec('/usr/bin/which mrc2any', $pathToMrc2any)

in the php file to detect and fill this field in automatically for the user? It could still be editable in case it needs to be changed or the which command fails to return anything.

Tested. Looks good.