Project

General

Profile

Actions

Bug #630

closed

subStack.php makes the first particle index to -1 in keepfile

Added by Anchi Cheng over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
-
Target version:
Start date:
06/04/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Appion/Leginon 2.0.1
Show in known bugs:
Workaround:

Description

I lost the last particle in ApStackParticle as a result even though the stack created still have the right number of particles when I enter 1 to the last particle in subStack.php

Actions #1

Updated by Anchi Cheng over 14 years ago

  • % Done changed from 0 to 100

I discussed it with Neil, Both substack.php and subtract 1 from the input starting particle number on the webpage to generate the subStack.py command. subStack.py substract 1 from that command parameter 'first' again to create the number that is saved to keepfile. As the result, including the first particle in the stack on substack.php input gives -1 in keepfile, not 0. We decided to just change substack.php since subStack.py is used at more places.

Also added the passing of rundir to the command.

trunk change r14285

Actions #2

Updated by Anchi Cheng over 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Pick-Wei Lau

Please check if any other places would be affected by this change.

Actions #3

Updated by Anchi Cheng over 14 years ago

  • Priority changed from High to Urgent
  • Target version set to Appion/Leginon 2.0.0

branch change in r14316

Actions #4

Updated by Amber Herold over 14 years ago

  • Status changed from In Code Review to Closed
  • Affected Version set to Appion/Leginon 2.0.1

We code reviewed and tested on Cronus3 and Guppy.

Actions

Also available in: Atom PDF