Bug #630
closed
subStack.php makes the first particle index to -1 in keepfile
Added by Anchi Cheng over 14 years ago.
Updated over 14 years ago.
Affected Version:
Appion/Leginon 2.0.1
Description
I lost the last particle in ApStackParticle as a result even though the stack created still have the right number of particles when I enter 1 to the last particle in subStack.php
- % Done changed from 0 to 100
I discussed it with Neil, Both substack.php and subtract 1 from the input starting particle number on the webpage to generate the subStack.py command. subStack.py substract 1 from that command parameter 'first' again to create the number that is saved to keepfile. As the result, including the first particle in the stack on substack.php input gives -1 in keepfile, not 0. We decided to just change substack.php since subStack.py is used at more places.
Also added the passing of rundir to the command.
trunk change r14285
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Pick-Wei Lau
Please check if any other places would be affected by this change.
- Priority changed from High to Urgent
- Target version set to Appion/Leginon 2.0.0
- Status changed from In Code Review to Closed
- Affected Version set to Appion/Leginon 2.0.1
We code reviewed and tested on Cronus3 and Guppy.
Also available in: Atom
PDF