Project

General

Profile

Actions

Bug #2302

open

Frealign refinejob form hp and lp are reversed

Added by Anchi Cheng over 11 years ago. Updated over 11 years ago.

Status:
In Code Review
Priority:
Normal
Category:
-
Target version:
-
Start date:
03/21/2013
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.0.0
Show in known bugs:
No
Workaround:

Description

selectPreparedRecon.php gives wrong RMAX1 and RMAX2 to frealign refinement and wrong help string.

Low resolution limit imposes a high-pass filter (hp)
High resolution limit imposes a low-pass filter (lp)

Actions #1

Updated by Anchi Cheng over 11 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Dmitry Lyumkis

r17480 switch the object.

testing:

1. Show the frealign refinement selection form such as myamiweb/processing/selectPreparedRecon.php?expId=9668
2. The RMAX1 should give help string for high-pass filter.
3. When default parameters are set, RMAX1 should be 300 while RMAX2 should be smaller number
4. When the command is displayed hp=300 and lp=10 should be the default.

Actions #2

Updated by Dmitry Lyumkis over 11 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Dmitry Lyumkis to Anchi Cheng

looks good, except that the default for "low-pass filter (lp)" should not say "2*nyquist"

Actions #3

Updated by Anchi Cheng over 11 years ago

  • Status changed from In Test to In Code Review
  • Assignee changed from Anchi Cheng to Dmitry Lyumkis

nice review. Switched in r17483

Actions

Also available in: Atom PDF