Project

General

Profile

Actions

Bug #2852

open

Makestack2Loop error

Added by David Veesler about 10 years ago. Updated about 10 years ago.

Status:
In Test
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
07/18/2014
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.0.0
Show in known bugs:
No
Workaround:

Description

It seems there is a problem during stack creation with the phase flipping using "EMAN phase flip Whole Image" (cf. below).

Traceback (most recent call last):
File "/opt/myamisnap/bin/makestack2.py", line 1213, in
makeStack.run()
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 90, in run
results = self.loopProcessImage(imgdata)
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 140, in loopProcessImage
return self.processImage(imgdata)
File "/opt/myamisnap/lib/appionlib/apParticleExtractor.py", line 504, in processImage
total_processed_particles = self.processParticles(imgdata,partdatas,shiftdata)
File "/opt/myamisnap/bin/makestack2.py", line 77, in processParticles
self.boxedpartdatas, self.imgstackfile, self.partmeantree = self.boxParticlesFromImage(imgdata,partdatas,shiftdata)

File "/opt/myamisnap/bin/makestack2.py", line 235, in boxParticlesFromImage
self._boxParticlesFromImage(imgdata,parttree, imgstackfile)
File "/opt/myamisnap/bin/makestack2.py", line 251, in _boxParticlesFromImage
imgpath = self.phaseFlipWholeImage(imgpath, imgdata)
File "/opt/myamisnap/bin/makestack2.py", line 555, in phaseFlipWholeImage
defocus, ampconst = self.getDefocusAmpConstForImage(imgdata, True)
AttributeError: 'Makestack2Loop' object has no attribute 'getDefocusAmpConstForImage

Actions #1

Updated by Gabriel Lander about 10 years ago

could this have something to do with Neil's recent update to makestack2.py for custom sorting of CTF values, r18426?

Actions #2

Updated by Neil Voss about 10 years ago

It was an EMAN1 CTF issue, fixed now, r18434.

Actions #3

Updated by Neil Voss about 10 years ago

  • Status changed from New to In Code Review
  • Assignee set to Amber Herold
Actions #4

Updated by Neil Voss about 10 years ago

  • Assignee changed from Amber Herold to Gabriel Lander
Actions #5

Updated by Gabriel Lander about 10 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Gabriel Lander to David Veesler

code looks fine, David could you test it out to make sure it's working properly?

Actions #6

Updated by David Veesler about 10 years ago

It doesn't work for me but maybe I am not pointing to the right install?
I am using cronus3.scripps.edu/betamyamiweb/
Thanks

Actions #7

Updated by Melody Campbell about 10 years ago

  • Assignee changed from David Veesler to Neil Voss

Hi,

I tried testing makestack with applying ctf using eman phase filp whole image.

The ctf has definitely been estimated on the image in question. (It's also the first images). Here is the error I get:

Starting image 1 ( skip:70, remain:525 ) id:3062172, file: 14jul17b_013sq_02hl_02en
... Pixel size: 1.36376
... Found 46 particles
... Boxing is done on /ami/data00/leginon/14jul17b/rawdata/14jul17b_00013sq_v02_00002hl_v02_00002en.mrc

no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
no best value
Traceback (most recent call last):
File "/opt/myamisnap/bin/makestack2.py", line 1213, in <module>
makeStack.run()
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 90, in run
results = self.loopProcessImage(imgdata)
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 140, in loopProcessImage
return self.processImage(imgdata)
File "/opt/myamisnap/lib/appionlib/apParticleExtractor.py", line 504, in processImage
total_processed_particles = self.processParticles(imgdata,partdatas,shiftdata)
File "/opt/myamisnap/bin/makestack2.py", line 77, in processParticles
self.boxedpartdatas, self.imgstackfile, self.partmeantree = self.boxParticlesFromImage(imgdata,partdatas,shiftdata)
File "/opt/myamisnap/bin/makestack2.py", line 235, in boxParticlesFromImage
self._boxParticlesFromImage(imgdata,parttree, imgstackfile)
File "/opt/myamisnap/bin/makestack2.py", line 251, in _boxParticlesFromImage
imgpath = self.phaseFlipWholeImage(imgpath, imgdata)
File "/opt/myamisnap/bin/makestack2.py", line 555, in phaseFlipWholeImage
defocus, ampconst = self.getDefocusAmpConstForImage(imgdata, True)
AttributeError: 'Makestack2Loop' object has no attribute 'getDefocusAmpConstForImage'

Actions #8

Updated by Neil Voss about 10 years ago

Can I get the command line and the directory?

Actions #9

Updated by Neil Voss about 10 years ago

Actually, it appears to be using the old version of the code that is why it crashed.

I will have to look why you are getting repeated "no best value" messages.

Actions #10

Updated by Melody Campbell about 10 years ago

Hi Neil,

In this directory there are 6 stack jobs all of which crashed:
/ami/data15/appion/14jul17b/stacks/

stack1 had already started before the change was made, so I don't know if that would be helpful to see exactly what changed and made it crash.

stack2 through 6 all have the same "no best value" error.

Let me know if you need any more information.

Actions #11

Updated by Amber Herold about 10 years ago

FYI,
Any changes made to the code will not be available in betamyamiweb until the next morning. If it is critical to have the fix today, Sargis will need to push the code manually.

Actions #12

Updated by Neil Voss about 10 years ago

Okay, all is working once you start running the latest version.

I was unable to reproduce the "no best value" errors, but I think that is because you are running makestack before all of the CTFFIND images have finished. It is pretty complex code, but I think is actually rejecting the images in this case.

Actions #13

Updated by David Veesler about 10 years ago

I believe the error comes from the fact we are not using the latest version (awaiting for the update to be made next night) as in my case ctffind was done estimating defocus.

Actions #14

Updated by Gabriel Lander about 10 years ago

my lab was able to get this working by removing the "--sort-type= " option from the command line. The Ward lab is also using this workaround until the trunk updates.

Actions #15

Updated by David Veesler about 10 years ago

Sargis, if it is not too much trouble for you, would you mind to please make the update?

Actions #16

Updated by Neil Voss about 10 years ago

Hmm, I am confused by your workaround Gabe. The code that fails is in EMAN1 applyctf and should not relate to sort type.

Actions #17

Updated by Gabriel Lander about 10 years ago

You're right, this is a separate issue - Is the garibaldi trunk updated automatically? I think that's the problem - the web interface was updated but the myami/trunk on garibaldi is still running an older version of myami.

Actions #18

Updated by Sargis Dallakyan about 10 years ago

Updated myami/trunk on garibaldi. JC gave me write access permission to myami trunk on garibaldi so I can update it when needed. I'll be out till next Friday. Please email if it needs to be updated again before that.

Actions #19

Updated by David Veesler about 10 years ago

Thanks Sargis for updating but the issue is still not fixed as i
am getting the same error message.

Actions #20

Updated by Bridget Carragher about 10 years ago

Can anyone who is avaible please try and resolve this! We have no pipeline if we can’t make stacks!
Can we at the very least revert back to the old makestack while we try and resolve this?
We really do need a trunk and a branch!

Actions #21

Updated by Neil Voss about 10 years ago

It sounds like you have several different myami versions all over the place.

Actions #22

Updated by Gabriel Lander about 10 years ago

Everything is running trunk. The trunk is updated on all web servers, workstations, and work nodes nightly EXCEPT garibaldi. Garibaldi is now updated to trunk, so everyone is using the same trunk version.
David, please send the makestack2.py command you're trying to run.

Actions #23

Updated by Melody Campbell about 10 years ago

Hi Gabe,

Here is an example of a makestack job file that doesn't work that I just submitted, after I took out the "--sort-type= " flag:

#!/bin/csh
#PBS -l walltime=240:00:00
#PBS -l nodes=1:ppn=2
#PBS -m e
#PBS -j oe
#PBS -V

  1. Target Host: guppy
  2. This job file has been created for the guppy processing host.
  3. Changes may be required to run this on another host.

updateAppionDB.py 327 R 416
webcaller.py '/opt/myamisnap/bin/appion makestack2.py --single=start.hed --selectionid=43 --invert --phaseflip --flip-type=emanimage --boxsize=448 --bin=2 --ctfrunid=12 --description="test again" --runname=stack11 --rundir=/ami/data15/appion/14jul17b/stacks/stack11 --commit --preset=en --projectid=416 --session=14jul17b --no-rejects --no-wait --continue --expid=13705 ' /ami/data15/appion/14jul17b/stacks/stack11/stack11.appionsub.log
updateAppionDB.py 327 D 416
exit

And the resulting error:
Starting image 1 ( skip:38, remain:557 ) id:3062172, file: 14jul17b_013sq_02hl_02en
... Pixel size: 1.36376
... Found 46 particles
... Boxing is done on /ami/data00/leginon/14jul17b/rawdata/14jul17b_00013sq_v02_00002hl_v02_00002en.mrc

Traceback (most recent call last):
File "/opt/myamisnap/bin/makestack2.py", line 1213, in <module>
makeStack.run()
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 90, in run
results = self.loopProcessImage(imgdata)
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 140, in loopProcessImage
return self.processImage(imgdata)
File "/opt/myamisnap/lib/appionlib/apParticleExtractor.py", line 504, in processImage
total_processed_particles = self.processParticles(imgdata,partdatas,shiftdata)
File "/opt/myamisnap/bin/makestack2.py", line 77, in processParticles
self.boxedpartdatas, self.imgstackfile, self.partmeantree = self.boxParticlesFromImage(imgdata,partdatas,shiftdata)
File "/opt/myamisnap/bin/makestack2.py", line 235, in boxParticlesFromImage
self._boxParticlesFromImage(imgdata,parttree, imgstackfile)
File "/opt/myamisnap/bin/makestack2.py", line 251, in _boxParticlesFromImage
imgpath = self.phaseFlipWholeImage(imgpath, imgdata)
File "/opt/myamisnap/bin/makestack2.py", line 555, in phaseFlipWholeImage
defocus, ampconst = self.getDefocusAmpConstForImage(imgdata, True)
AttributeError: 'Makestack2Loop' object has no attribute 'getDefocusAmpConstForImage'

the ctf has been estimated for the entire data set.

Thanks!!

Actions #24

Updated by Neil Voss about 10 years ago

Hi Melody and Gabe, You may be importing an older version of myami in the PYTHONPATH, the fix is in apParticleExtration.py in appionlib.

I have to pick up the kids in 20 minutes, so if you can try it quickly then I can help, but otherwise I will check my email again at 9pm Central (7pm Pacific).

Actions #25

Updated by Neil Voss about 10 years ago

Hi Melody, I think you'll have to wait until overnight for things to work.

"The trunk is updated on all web servers, workstations, and work nodes nightly"

Actions #26

Updated by Bridget Carragher about 10 years ago

Hi Neil - no I don;t think that is it as Sargis did a push update today. Bridget

Actions #27

Updated by Neil Voss about 10 years ago

Well, I just checked and it was not updated on guppy.

Actions #28

Updated by Bridget Carragher about 10 years ago

Oh OK, thanks Sorry. So we may all be chasing shadows here.

Actions #29

Updated by Melody Campbell about 10 years ago

Hi,

I've submitted a similar job on garibaldi (also removing the "--sort-type= " flag). So far it is running!!

Thanks all!

Actions #30

Updated by David Veesler about 10 years ago

Just tried on garibaldi using the option "only use ctffind values" and it works as well.

Thanks a lot.

David

Actions

Also available in: Atom PDF